Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setDuration, setProgress and getCompletedSegments. #4

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added setDuration, setProgress and getCompletedSegments. #4

wants to merge 2 commits into from

Conversation

luca992
Copy link

@luca992 luca992 commented Jul 13, 2017 •
edited by carlosmuvi
Loading

Changelog

  • Added getCompletedSegments.
  • Changed indentation from 4 to 2 spaces
  • Added setDuration and setProgress

luca992 added 2 commits July 12, 2017 18:24
@luca992
add ability to set segment duration and set progress manually. add ge…
b1db301 
…tter for completed segments
@luca992
Merge branch 'master' of https://github.com/luca992/SegmentedProgressBar
8592793 
 into set_progress_manually

# Conflicts:
#	library/src/main/java/com/carlosmuvi/segmentedprogressbar/SegmentedProgressBar.kt
carlosmuvi
carlosmuvi requested changes Aug 5, 2017
View reviewed changes
Copy link
Owner

@carlosmuvi carlosmuvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! I updated the PR description to appropriately explain your updates.

I find the new features quite useful, but I'll keep the 2 spaces indentation (I'm using the SquareAndroid codestyle - https://github.com/square/java-code-styles/blob/master/configs/codestyles/SquareAndroid.xml)

@carlosmuvi
Copy link
Owner

@luca992 also, please open the PR against develop please :)

@carlosmuvi carlosmuvi changed the title I needed the ability to directly control the progress. I have added support for that Added setDuration, setProgress and getCompletedSegments. Aug 5, 2017
@carlosmuvi carlosmuvi changed the base branch from master to develop November 3, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmuvi carlosmuvi carlosmuvi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca992 @carlosmuvi